Support rendering | null syntax for nullable values in tooltips
#1353
+132
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad in test result view
…nfo for FSharpType instances
baronfel
force-pushed
the
tooltip-nullability
branch
from
cb2f2be to
de0b1ec
Compare
baronfel
force-pushed
the
tooltip-nullability
branch
from
de0b1ec to
e38caff
Compare
baronfel
force-pushed
the
tooltip-nullability
branch
from
34e368c to
cfe80b7
Compare
|
This got really hairy. The code seems to work, but for scripts specifically it requires passing |
|
We may enable nulls for all .NET 9 usage of scripts as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352 by checking the nullability information on FSharpType and using that to determine if we should slap a
| nullon the formatted type.